Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle correctly when body is empty #529

Conversation

sileht
Copy link
Member

@sileht sileht commented Oct 25, 2024

GitHub randomly returns None or ""

Depends-On: #520

@sileht
Copy link
Member Author

sileht commented Oct 25, 2024

This pull request is part of a stack:

  1. feat: allow to pass author (#520)
  2. fix: handle correctly when body is empty (#529) 👈
  3. feat: add stack checkout (#523)
  4. feat: add stack github-action-auto-rebase command (#527)

Copy link
Contributor

mergify bot commented Oct 25, 2024

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

⛓️ Depends-On Requirements

Requirement based on the presence of Depends-On in the body of the pull request

Changelog requirements

  • any of:
    • -title ~= ^feat
    • label = need changelog
    • label = skip changelog

Enforce conventional commit

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

🔎 Reviews

  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

@sileht sileht changed the base branch from devs/sileht/merged-handling/I419a57f50240d69a92f56f2355ad2b0b5d2a8d8c to devs/sileht/merged-handling/I1c850e473aa086afe1f30a194e0da99d29c6bfa9 October 25, 2024 19:07
@sileht sileht force-pushed the devs/sileht/merged-handling/I72dd27ae39fc410fba636296be2117565d1d8d40 branch from 34ad212 to f6dd0e4 Compare October 25, 2024 19:07
@sileht sileht force-pushed the devs/sileht/merged-handling/I1c850e473aa086afe1f30a194e0da99d29c6bfa9 branch from 00a9f0b to ad2fb75 Compare October 28, 2024 16:03
@sileht sileht force-pushed the devs/sileht/merged-handling/I72dd27ae39fc410fba636296be2117565d1d8d40 branch from f6dd0e4 to 4b89d98 Compare October 28, 2024 16:03
@sileht sileht force-pushed the devs/sileht/merged-handling/I1c850e473aa086afe1f30a194e0da99d29c6bfa9 branch from ad2fb75 to 31e9295 Compare October 29, 2024 08:22
@sileht sileht force-pushed the devs/sileht/merged-handling/I72dd27ae39fc410fba636296be2117565d1d8d40 branch from 4b89d98 to 92c0fa8 Compare October 29, 2024 08:22
Greesb
Greesb previously approved these changes Oct 29, 2024
@sileht sileht force-pushed the devs/sileht/merged-handling/I1c850e473aa086afe1f30a194e0da99d29c6bfa9 branch from 31e9295 to ed26601 Compare October 29, 2024 09:35
@sileht sileht force-pushed the devs/sileht/merged-handling/I72dd27ae39fc410fba636296be2117565d1d8d40 branch from 92c0fa8 to 78ca2a3 Compare October 29, 2024 09:36
@mergify mergify bot dismissed Greesb’s stale review October 29, 2024 09:36

Pull request has been modified.

Greesb
Greesb previously approved these changes Oct 29, 2024
This is required to find the stacked pull request if the stack is not
owned by the owner of the token.

This will be leverage to run mergify-cli inside an GitHub action.

Change-Id: I1c850e473aa086afe1f30a194e0da99d29c6bfa9
GitHub randomly returns None or ""

Change-Id: I72dd27ae39fc410fba636296be2117565d1d8d40
@sileht sileht force-pushed the devs/sileht/merged-handling/I1c850e473aa086afe1f30a194e0da99d29c6bfa9 branch from ed26601 to ed222b0 Compare October 29, 2024 09:52
@sileht sileht force-pushed the devs/sileht/merged-handling/I72dd27ae39fc410fba636296be2117565d1d8d40 branch from 78ca2a3 to 5fbc721 Compare October 29, 2024 09:52
@mergify mergify bot dismissed Greesb’s stale review October 29, 2024 09:53

Pull request has been modified.

@mergify mergify bot requested a review from a team October 29, 2024 09:53
Base automatically changed from devs/sileht/merged-handling/I1c850e473aa086afe1f30a194e0da99d29c6bfa9 to main October 29, 2024 11:01
@Greesb Greesb removed the request for review from a team October 29, 2024 11:02
mergify bot added a commit that referenced this pull request Oct 29, 2024
@mergify mergify bot added the queued label Oct 29, 2024
@mergify mergify bot merged commit a61301e into main Oct 29, 2024
5 checks passed
@mergify mergify bot deleted the devs/sileht/merged-handling/I72dd27ae39fc410fba636296be2117565d1d8d40 branch October 29, 2024 11:04
@mergify mergify bot removed the queued label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants